Skip to content

test: enable React.StrictMode #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2020
Merged

test: enable React.StrictMode #593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 26 additions & 19 deletions test/CSSTransitionGroup-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ let TransitionGroup;
describe('CSSTransitionGroup', () => {
let container;
let consoleErrorSpy;
let render;

function YoloTransition({ id, ...props }) {
const nodeRef = React.useRef()
Expand All @@ -27,6 +28,12 @@ describe('CSSTransitionGroup', () => {
React = require('react');
ReactDOM = require('react-dom');

render = (element, container, callback) => ReactDOM.render(
<React.StrictMode>{element}</React.StrictMode>,
container,
callback
)

TransitionGroup = require('../src/TransitionGroup');

container = document.createElement('div');
Expand All @@ -39,7 +46,7 @@ describe('CSSTransitionGroup', () => {


it('should clean-up silently after the timeout elapses', () => {
ReactDOM.render(
render(
<TransitionGroup enter={false}>
<YoloTransition key="one" id="one"/>
</TransitionGroup>,
Expand All @@ -50,7 +57,7 @@ describe('CSSTransitionGroup', () => {

expect(transitionGroupDiv.childNodes.length).toBe(1);

ReactDOM.render(
render(
<TransitionGroup enter={false}>
<YoloTransition key="two" id="two"/>
</TransitionGroup>,
Expand All @@ -72,7 +79,7 @@ describe('CSSTransitionGroup', () => {
});

it('should keep both sets of DOM nodes around', () => {
ReactDOM.render(
render(
<TransitionGroup>
<YoloTransition key="one" id="one" />
</TransitionGroup>,
Expand All @@ -83,7 +90,7 @@ describe('CSSTransitionGroup', () => {

expect(transitionGroupDiv.childNodes.length).toBe(1);

ReactDOM.render(
render(
<TransitionGroup>
<YoloTransition key="two" id="two" />
</TransitionGroup>,
Expand All @@ -96,7 +103,7 @@ describe('CSSTransitionGroup', () => {
});

it('should switch transitionLeave from false to true', () => {
ReactDOM.render(
render(
<TransitionGroup enter={false} leave={false}>
<YoloTransition key="one" id="one" />
</TransitionGroup>,
Expand All @@ -107,7 +114,7 @@ describe('CSSTransitionGroup', () => {

expect(transitionGroupDiv.childNodes.length).toBe(1);

ReactDOM.render(
render(
<TransitionGroup enter={false} leave={false}>
<YoloTransition key="two" id="two" />
</TransitionGroup>,
Expand All @@ -118,7 +125,7 @@ describe('CSSTransitionGroup', () => {

expect(transitionGroupDiv.childNodes.length).toBe(1);

ReactDOM.render(
render(
<TransitionGroup enter={false} leave>
<YoloTransition key="three" id="three" />
</TransitionGroup>,
Expand All @@ -132,7 +139,7 @@ describe('CSSTransitionGroup', () => {


it('should work with a null child', () => {
ReactDOM.render(
render(
<TransitionGroup>
{[null]}
</TransitionGroup>,
Expand All @@ -144,26 +151,26 @@ describe('CSSTransitionGroup', () => {
const NullComponent = () => null;
// Testing the whole lifecycle of entering and exiting,
// because those lifecycle methods used to fail when the DOM node was null.
ReactDOM.render(
render(
<TransitionGroup/>,
container,
);
ReactDOM.render(
render(
<TransitionGroup>
<CSSTransition classNames="yolo" timeout={0}>
<NullComponent/>
</CSSTransition>
</TransitionGroup>,
container,
);
ReactDOM.render(
render(
<TransitionGroup/>,
container,
);
});

it('should transition from one to null', () => {
ReactDOM.render(
render(
<TransitionGroup>
<YoloTransition key="one" id="one" />
</TransitionGroup>,
Expand All @@ -174,7 +181,7 @@ describe('CSSTransitionGroup', () => {

expect(transitionGroupDiv.childNodes.length).toBe(1);

ReactDOM.render(
render(
<TransitionGroup>
{null}
</TransitionGroup>,
Expand All @@ -188,7 +195,7 @@ describe('CSSTransitionGroup', () => {
});

it('should transition from false to one', () => {
ReactDOM.render(
render(
<TransitionGroup>
{false}
</TransitionGroup>,
Expand All @@ -199,7 +206,7 @@ describe('CSSTransitionGroup', () => {

expect(transitionGroupDiv.childNodes.length).toBe(0);

ReactDOM.render(
render(
<TransitionGroup>
<YoloTransition key="one" id="one" />
</TransitionGroup>,
Expand All @@ -221,8 +228,8 @@ describe('CSSTransitionGroup', () => {
}
}

ReactDOM.render(<Component />, container);
ReactDOM.render(
render(<Component />, container);
render(
<Component>
<YoloTransition key="yolo" id="yolo" />
</Component>,
Expand Down Expand Up @@ -259,7 +266,7 @@ describe('CSSTransitionGroup', () => {
}
}

ReactDOM.render(<Component />, container);
render(<Component />, container);

// Testing that no exception is thrown here, as the timeout has been cleared.
jest.runAllTimers();
Expand Down Expand Up @@ -298,7 +305,7 @@ describe('CSSTransitionGroup', () => {
}
}

ReactDOM.render(<Component />, container);
render(<Component />, container);
const transitionGroupDiv = container.childNodes[0]
transitionGroupDiv.childNodes.forEach(child => {
expect(hasClass(child, extraClassNameProp)).toBe(true);
Expand Down
16 changes: 11 additions & 5 deletions test/TransitionGroup-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,20 @@ let Transition
// Most of the real functionality is covered in other unit tests, this just
// makes sure we're wired up correctly.
describe('TransitionGroup', () => {
let container, log, Child
let container, log, Child, render;

beforeEach(() => {
React = require('react')
ReactDOM = require('react-dom')
Transition = require('../src/Transition').default
TransitionGroup = require('../src/TransitionGroup')

render = (element, container, callback) => ReactDOM.render(
<React.StrictMode>{element}</React.StrictMode>,
container,
callback
)

container = document.createElement('div')

log = []
Expand Down Expand Up @@ -70,7 +76,7 @@ describe('TransitionGroup', () => {
})

it('should work with no children', () => {
ReactDOM.render(<TransitionGroup />, container)
render(<TransitionGroup />, container)
})

it('should handle transitioning correctly', () => {
Expand All @@ -85,18 +91,18 @@ describe('TransitionGroup', () => {
}

jest.useFakeTimers()
ReactDOM.render(<Parent />, container)
render(<Parent />, container)

jest.runAllTimers()
expect(log).toEqual(['appear', 'appearing', 'appeared'])

log = []
ReactDOM.render(<Parent count={2} />, container)
render(<Parent count={2} />, container)
jest.runAllTimers()
expect(log).toEqual(['enter', 'entering', 'entered'])

log = []
ReactDOM.render(<Parent count={1} />, container)
render(<Parent count={1} />, container)
jest.runAllTimers()
expect(log).toEqual(['exit', 'exiting', 'exited'])
})
Expand Down