Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve embedded coding examples #246

Open
1 of 4 tasks
bvaughn opened this issue Nov 6, 2017 · 3 comments
Open
1 of 4 tasks

Improve embedded coding examples #246

bvaughn opened this issue Nov 6, 2017 · 3 comments

Comments

@bvaughn
Copy link
Contributor

bvaughn commented Nov 6, 2017

Follow-up for #245:

@bvaughn
Copy link
Contributor Author

bvaughn commented Nov 7, 2017

I'm not sure that adding direct links to view example source files in GitHub is worth doing. (I'm not sure it will actually address the accessibility concern.) So I'm going to hold off on doing this unless someone who knows more about this than I do confirms it as a worthwhile course of action.

@bvaughn
Copy link
Contributor Author

bvaughn commented Nov 8, 2017

I'm going to combine the 2 Gatsby plug-ins I created recently (gatsby-remark-babel-repl-link and gatsby-remark-codepen-examples) into a single plug-in (gatsby-remark-code-repls) that can be shared upstream with Gatsby. This way others can use it too. I've talked with Kyle about this and he thinks it will be useful to others as well. Once it's been merged, I'll update this repo to use the new shared plug-in rather than the 2 local ones.

Edit: See PRs #262 and gatsbyjs/gatsby/pull/2848

@micpap25
Copy link

Hi @bvaughn , did the PR from @danielsbird fully resolve this issue? If it did, I think this can be closed. If not, could you let me know what needs to be done to finish this issue? Thank you.

BetterZxx pushed a commit to BetterZxx/react.dev that referenced this issue Mar 21, 2023
…#246)

* fix:wrong spelling in tutorial

* fix: modify the statement is not smooth
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants