2020 Community survey banner #3289
Conversation
|
Deploy preview for reactjs ready! Built with commit 1eec972 |
|
I'm seeing some console warnings.
The second one seems important. It says the DOM structure isn't valid (nested links) which causes unpredictable behavior in React. |
|
Doesn't look good on iPhone. I think we need fewer words.
|
There was a problem hiding this comment.
Need to fix nested links (both from the technical standpoint and from the design one — I find it a bit confusing we have a blue link call to action but actually the whole thing except margins is also a link).
Need to fix display on small screens, probably by shortening the message.
This reverts commit 3dddae8.
|
Force-pushed my changes to this branch. |
bvaughn
force-pushed
the
2020-survey
branch
from
de7a2ba to
352e3cd
Compare
|
If you guys could deactivate the banner as the survey has already expired... I can open a PR 😃 |
|
Oh, that doesn't seem good. The survey wasn't supposed to expire until December 13th. |
|
No, it was supposed to expire (the original date had a typo that's been fixed). @espipj Are you saying you are seeing the banner? It isn't supposed to be showing for several weeks by now. |
|
@gaearon still there Once you dismiss it keeps closed in the following visits at least :) |
|
Funny enough it seems that it only shows up on Firefox lol: |
|
That appears to be because Firefox parses the date strictly and won't let you leave off the time in ISO format. So these two lines are not valid: |
|
Nice catch, @alexkrolick. A PR that fixes this would be welcome (from anyone in the above thread). |
Adds a banner for our 2020 community survey. The banner opens and closes and won't be visible until Sept 30th. It will disappear and be ready for code removal after Oct 12