Skip to content

Conversation

danilowoz
Copy link
Contributor

Unfortunately, I'm reverting the minimal babel implementation made on #5164, as it proves that unhandled custom plugins like dynamic imports and others we're not aware of. So, here's the plan:

  1. Rollback immediately in order to fix the issues;
  2. Sucrase: we've been playing with it a bit, and we're looking forward to implementing the missing pieces to replace Babel (which is huge) with Sucrase. We can't make any promises, but we're actively working on it, and we can expect something soon;

@gaearon, I think we should merge this asap.

Fix #5244, fix #5241

@github-actions
Copy link

github-actions bot commented Nov 7, 2022

Size Changes

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 89.02 KB (-1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

@harish-sethuraman harish-sethuraman merged commit ec368f4 into reactjs:main Nov 7, 2022
@gaearon
Copy link
Member

gaearon commented Nov 11, 2022

Does this revert Babel alone, or also the caching improvements?

@danilowoz
Copy link
Contributor Author

It only reverts the Babel configuration. All the cache optimization and other improvements are still working

@danilowoz danilowoz deleted the draft/reverent-wildflower branch November 11, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Beta] [Bug] Click on Show Preview checkbox shows an error [Beta] [Bug] Reacting to a input with State : pressing the submit button shows an error
4 participants