Fix improper idiom usage #5883
Merged
Fix improper idiom usage #5883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's 5 instances in this document in which the casing of a file name begins with lower case, which makes it inconsisnent both with the page and the entire tutorial.
The phrase "most of the times" is incorrect and would only make sense in the context of a larger sentence. The phrase is actually "most of the time" and is used in place of "usually".
|
|
||
| When you write a _default_ import, you can put any name you want after `import`. For example, you could write `import Banana from './button.js'` instead and it would still provide you with the same default export. In contrast, with named imports, the name has to match on both sides. That's why they are called _named_ imports! | ||
| When you write a _default_ import, you can put any name you want after `import`. For example, you could write `import Banana from './Button.js'` instead and it would still provide you with the same default export. In contrast, with named imports, the name has to match on both sides. That's why they are called _named_ imports! |
There was a problem hiding this comment.
These changes were merged in this PR.
There was a problem hiding this comment.
@harish-sethuraman I'm very new to using Github, could you explain to me why it was that I pushed that old commit? Or direct to me a resource that explains? I did the same process for the second of the two commits, ie made sure everything was up to date from main branch, but for some reason the same one went through twice.
There was a problem hiding this comment.
you probably created the second branch from your first branch rather than from main. so it included your last commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The phrase "most of the times" is incorrect and would only make sense
in the context of a larger sentence. The phrase is actually "most of the
time" and is used in place of "usually".