Skip to content

Add branding context menu #6986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Conversation

rickhanlonii
Copy link
Member

Overview

Adds a menu when you right click the top nav logo to copy the logos and colors.

Screens

Dark mode

Screenshot 2024-06-20 at 10 48 46 AM

Light mode

Screenshot 2024-06-20 at 10 48 39 AM

uwu

Screenshot 2024-06-20 at 10 49 03 AM

Copy link

vercel bot commented Jun 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
19-react-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2024 2:52pm
react-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2024 2:52pm

@kassens
Copy link
Collaborator

kassens commented Jun 20, 2024

Do we have branding guidelines that should be linked near this place?

Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 104.19 KB (🟡 +50 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 104.28 KB (🔴 +23.49 KB) 208.47 KB
/500 104.27 KB (🔴 +23.49 KB) 208.46 KB
/[[...markdownPath]] 106.12 KB (🔴 +23.49 KB) 210.31 KB
/errors 104.48 KB (🔴 +23.49 KB) 208.68 KB
/errors/[errorCode] 104.46 KB (🔴 +23.49 KB) 208.66 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@rickhanlonii
Copy link
Member Author

@kassens let's follow up with that, I'm not sure exactly what we need for the guidelines

@rickhanlonii rickhanlonii merged commit 169d5c1 into reactjs:main Jun 20, 2024
6 checks passed
@rickhanlonii rickhanlonii deleted the rh/branding branch June 20, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants