Minor: context/theme-detailed-app.js broken #746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today I tested out the new Context API using using [CRA](https://github.com/facebook/create-react-app). I encountered a runtime exception, so this tiny PR is intended to make it easier for future Context API learners. `ReferenceError: Must call super constructor in derived class before accessing 'this' or returning from derived constructor` create-react-app@next commit da518d2238298dd5db74e9c63c12251099f87bb0
|
Deploy preview for reactjs ready! Built with commit b2c2d69 |
|
Looks like it worked. Courtesy of Netlify: |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today I tested out the new Context API using using CRA.
I copy/pasted the example in, and was surprised to encounter a runtime exception.
So this tiny PR is intended to make things easier for future Context API learners.
ReferenceError: Must call super constructor in derived class before accessing 'this' or returning from derived constructor