Restore lint corrections from #7989 #7997
Conversation
poteto
force-pushed
the
pr7997
branch
2 times, most recently
from
0488373 to
2cb3cbc
Compare
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Five Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
Previously, `createFileMap` split the MDX meta string on spaces and assumed the first token was the filename. Once we prefixed code fences with `{expectedErrors: ...}`, it would incorrectly parse the meta and crash.
This PR updates createFileMap to skip tokens in the meta containing a start and end brace pair (using a stack to ensure we close on the correct brace) while tokenizing the meta string as expected.
Test plan: pages reported in #7994 no longer crash on the next PR
Closes #7994
Reverts the revert now that we've fixed the bug. These pages should no longer crash: https://react-dev-git-pr7997-fbopensource.vercel.app/learn/referencing-values-with-refs https://react-dev-git-pr7997-fbopensource.vercel.app/learn/synchronizing-with-effects https://react-dev-git-pr7997-fbopensource.vercel.app/learn/separating-events-from-effects https://react-dev-git-pr7997-fbopensource.vercel.app/learn/removing-effect-dependencies https://react-dev-git-pr7997-fbopensource.vercel.app/learn/you-might-not-need-an-effect
Reverts the revert now that we've fixed the bug. These pages should no longer crash:
https://react-dev-git-pr7997-fbopensource.vercel.app/learn/referencing-values-with-refs
https://react-dev-git-pr7997-fbopensource.vercel.app/learn/synchronizing-with-effects
https://react-dev-git-pr7997-fbopensource.vercel.app/learn/separating-events-from-effects
https://react-dev-git-pr7997-fbopensource.vercel.app/learn/removing-effect-dependencies
https://react-dev-git-pr7997-fbopensource.vercel.app/learn/you-might-not-need-an-effect
Stack created with Sapling. Best reviewed with ReviewStack.