Fix Activity sandboxes #8035
Merged
Fix Activity sandboxes #8035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
|
well, that doesn't work |
|
This is a total hack, it looks like sandpack is resolving to the wrong versions. Like if you put import { unstable_Activity, Activity as ActivityStable} from 'react';
let Activity = ActivityStable ?? unstable_Activity;Until we figure out how to fix sandpack. |
|
I'm looking at this now. Will try to repro it on my side and see what we need to fix to resolve 19.2 correctly! |
eps1lon
pushed a commit
that referenced
this pull request
Oct 2, 2025
* Fix Activity sandboxes * hacky fix
rickhanlonii
added a commit
that referenced
this pull request
Oct 2, 2025
* Use stable release in demos with HTML output * Fix Activity sandboxes (#8035) * Fix Activity sandboxes * hacky fix * Revert "Fix Activity sandboxes (#8035)" This reverts commit f9fd07c. * Bump to 19.2 * cleanup rest of sandpacks * Pin deps * Add back package.json with third-party deps * "^" should be fixed now * add back package.json for more toastify deps * fuggin whitespace * more fuggin whitespace * fml like fr fr --------- Co-authored-by: Sebastian Sebbie Silbermann <sebastian.silbermann@vercel.com> Co-authored-by: Ricky <rickhanlonii@gmail.com> Co-authored-by: Rick Hanlon <rickhanlonii@meta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully fixes #8034