Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate "DOM elements" #88

Merged
merged 10 commits into from
Feb 21, 2019
Merged

Translate "DOM elements" #88

merged 10 commits into from
Feb 21, 2019

Conversation

ivankaizer
Copy link
Contributor

No description provided.

@ivankaizer ivankaizer mentioned this pull request Feb 11, 2019
Closed
88 tasks
@another-guy another-guy added the needs review A pull request ready to be reviewed label Feb 11, 2019
lex111
lex111 reviewed Feb 12, 2019
View reviewed changes
Copy link
Member

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Хорошее начало, оставил комментарии для улучшения перевода.

content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
angryermine
angryermine reviewed Feb 13, 2019
View reviewed changes
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
gcor
gcor reviewed Feb 14, 2019
View reviewed changes
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
@lex111 lex111 added work in progress Author opened the pull-request but it's still being worked on needs review A pull request ready to be reviewed and removed needs review A pull request ready to be reviewed labels Feb 15, 2019
angryermine and others added 2 commits February 15, 2019 19:45
@angryermine @ivankaizer
Update content/docs/reference-dom-elements.md
7eee002 
Co-Authored-By: ivankayzer <ivan.kayzer@outlook.com>
@ivankaizer
Apply suggestions from code review
c057454 
Co-Authored-By: ivankayzer <ivan.kayzer@outlook.com>
@another-guy another-guy self-assigned this Feb 16, 2019
@lex111 lex111 removed the work in progress Author opened the pull-request but it's still being worked on label Feb 16, 2019
gcor
gcor reviewed Feb 17, 2019
View reviewed changes
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
ivankaizer and others added 3 commits February 17, 2019 21:27
@ivankaizer
Apply suggestions from code review
56cca85 
Co-Authored-By: ivankayzer <ivan.kayzer@outlook.com>
@gcor @ivankaizer
Update content/docs/reference-dom-elements.md
e344922 
Co-Authored-By: ivankayzer <ivan.kayzer@outlook.com>
@ivankaizer
Update reference-dom-elements.md
cd8623b
another-guy
another-guy requested changes Feb 17, 2019
View reviewed changes
Copy link
Collaborator

@another-guy another-guy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Очередной качественный перевод, ревьють который — одно удовольствие. 👍 ❤️ 🎉

Несколько комментариев про дефис/тире, мене английский порядок слов в предложении, и ненужные слова.

content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
@another-guy another-guy added work in progress Author opened the pull-request but it's still being worked on and removed needs review A pull request ready to be reviewed labels Feb 17, 2019
@another-guy another-guy removed their assignment Feb 20, 2019
@another-guy @ivankaizer
Apply suggestions from code review
1f4bf6a 
Co-Authored-By: ivankayzer <ivan.kayzer@outlook.com>
@netlify
Copy link

netlify bot commented Feb 21, 2019

Deploy preview for ru-reactjs ready!

Built with commit 1f4bf6a

https://deploy-preview-88--ru-reactjs.netlify.com

@netlify
Copy link

netlify bot commented Feb 21, 2019 •
edited
Loading

Deploy preview for ru-reactjs ready!

Built with commit 8aac5e7

https://deploy-preview-88--ru-reactjs.netlify.com

@another-guy another-guy merged commit 3b711ea into reactjs:master Feb 21, 2019
@another-guy another-guy added needs proofread A read-through is still needed to release the document and removed work in progress Author opened the pull-request but it's still being worked on labels Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gcor gcor gcor left review comments

@lex111 lex111 lex111 approved these changes

@angryermine angryermine angryermine left review comments

@another-guy another-guy another-guy approved these changes

Assignees
No one assigned
Labels
needs proofread A read-through is still needed to release the document
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ivankaizer @angryermine @lex111 @gcor @another-guy