Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Navigation & Profiler API #199

Merged
merged 12 commits into from
Sep 16, 2021
Merged

Translate Navigation & Profiler API #199

merged 12 commits into from
Sep 16, 2021

Conversation

fozg
Copy link
Contributor

@fozg fozg commented Sep 15, 2021

No description provided.

@netlify
Copy link

netlify bot commented Sep 15, 2021

✔️ Deploy Preview for vi-reactjs-org ready!

🔨 Explore the source changes: 774c825

🔍 Inspect the deploy log: https://app.netlify.com/sites/vi-reactjs-org/deploys/6142b3a9331f99000715b1ec

😎 Browse the preview: https://deploy-preview-199--vi-reactjs-org.netlify.app

@@ -5,28 +5,28 @@
- id: add-react-to-a-website
title: Thêm React vào một Website
- id: create-a-new-react-app
title: Tạo một App React mới
title: Tạo một ứng dụng React mới
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chỗ này giữ App sẽ hợp lý hơn nè

- id: portals
title: Portals
- id: profiler
title: Profiler
- id: react-without-es6
title: React Without ES6
title: React không sử dụng ES6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

React "nhưng" không sử dụng ES6

Do câu trên đọc sợ người đọc hiểu lầm là Reactjs ko có sử dụng ES6 toàn bộ luôn ấy

- id: react-without-jsx
title: React Without JSX
title: React không sử dụng JSX
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tương tự trên bạn nhé

@fozg fozg changed the title Translate Navigation texts Translate Navigation & Profiler API Sep 15, 2021
@@ -103,9 +103,9 @@
- id: test-renderer
title: Test Renderer
- id: javascript-environment-requirements
title: JS Environment Requirements
title: Yêu cầu môi trường JS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-> Môi trường JS yêu cầu
Mình nghĩ vậy đúng ngữ nghĩa hơn nè

content/docs/nav.yml Outdated Show resolved Hide resolved
Copy link
Member

@Ryan-LT Ryan-LT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇 Best!

@Ryan-LT Ryan-LT merged commit ada3dd8 into reactjs:main Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants