Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation: Responding to Events #359

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

phuc1nguyen
Copy link

@phuc1nguyen phuc1nguyen commented May 2, 2023

  • Overview
  • Adding event handlers
  • Event propagation
  • Can event handlers have side effects?
  • Recap

@phuc1nguyen phuc1nguyen changed the title Translation for Responding to Events page Translation: Responding to Events May 2, 2023
@phuc1nguyen
Copy link
Author

phuc1nguyen commented May 2, 2023

Hi maintainers, since this is not a short page and it's my first translation, could I get a quick review to see whether I'm heading in the right direction?

Like, I'm using both prop and props, is it ok or it should be prop and các/những prop since we keep props untranslated?

Thanks in advance!

@ltmylinh
Copy link
Collaborator

ltmylinh commented May 9, 2023

Hi maintainers, since this is not a short page and it's my first translation, could I get a quick review to see whether I'm heading in the right direction?

Like, I'm using both prop and props, is it ok or it should be prop and các/những prop since we keep props untranslated?

Thanks in advance!

IMO, we can keep prop and các/những prop. Thanks :)

@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 76.1 KB (🟢 -45 B) 169.73 KB
/500 76.09 KB (🟢 -45 B) 169.72 KB
/[[...markdownPath]] 77.52 KB (🟢 -45 B) 171.15 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants