Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete lists-and-keys #17

Merged
merged 6 commits into from
Feb 21, 2019
Merged

Complete lists-and-keys #17

merged 6 commits into from
Feb 21, 2019

Conversation

chloewlin
Copy link
Member

I completed lists and keys.

The only thing I am not sure about is inline on line 283. We can keep it as it is if we cannot think of a better word.

@netlify
Copy link

netlify bot commented Feb 19, 2019

Deploy preview for zh-hant-reactjs ready!

Built with commit 27c8f77

https://deploy-preview-17--zh-hant-reactjs.netlify.com

Copy link
Contributor

@ivan-ha ivan-ha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems changes you made in #9 are included, maybe checking out a new branch just for lists and keys?

@netlify
Copy link

netlify bot commented Feb 21, 2019

Deploy preview for zh-hant-reactjs-org ready!

Built with commit 27c8f77

https://deploy-preview-17--zh-hant-reactjs-org.netlify.com

@chloewlin chloewlin merged commit 69970b3 into reactjs:master Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants