Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[build] Separate publish build on several jobs #2379

Merged
merged 3 commits into from
Jul 13, 2022
Merged

[build] Separate publish build on several jobs #2379

merged 3 commits into from
Jul 13, 2022

Conversation

violetagg
Copy link
Member

No description provided.

@violetagg violetagg added the type/chore A task not related to code (build, formatting, process, ...) label Jul 13, 2022
@violetagg violetagg added this to the 1.0.22 milestone Jul 13, 2022
@violetagg
Copy link
Member Author

@simonbasle PTAL

simonbasle
simonbasle reviewed Jul 13, 2022
View reviewed changes
Copy link
Member

@simonbasle simonbasle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like an easy path to parallelize the testing phase 👍 suggested a few improvements inline

.github/workflows/publish.yml Outdated Show resolved Hide resolved
.github/workflows/publish.yml Outdated Show resolved Hide resolved
.github/workflows/publish.yml Outdated Show resolved Hide resolved
pderop
pderop previously approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@pderop pderop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pderop pderop dismissed their stale review July 13, 2022 09:48

Dismissing my approval, since I was not asked to review this PR.

@violetagg
Copy link
Member Author

@pderop @simonbasle Thanks

@violetagg violetagg merged commit 71d0c28 into 1.0.x Jul 13, 2022
@violetagg violetagg deleted the publish-separate-jobs branch July 13, 2022 11:50
violetagg added a commit that referenced this pull request Jul 13, 2022
@violetagg
Merge #2379 into 1.1.0-M5
8674d9d
violetagg added a commit that referenced this pull request Jul 13, 2022
@violetagg
Merge #2379 into netty5
577761a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonbasle simonbasle simonbasle approved these changes

@pderop pderop pderop left review comments

Assignees
No one assigned
Labels
type/chore A task not related to code (build, formatting, process, ...)
Projects
None yet
Milestone
1.0.22
Development

Successfully merging this pull request may close these issues.
3 participants
@violetagg @pderop @simonbasle