Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #285 - connection close should always be bridged to pool release #286

Merged
merged 1 commit into from
Feb 14, 2018

Conversation

smaldini
Copy link
Contributor

No description provided.

@smaldini smaldini added the type/bug A general bug label Feb 14, 2018
@smaldini smaldini added this to the 0.7.4.RELEASE milestone Feb 14, 2018
@codecov-io
Copy link

codecov-io commented Feb 14, 2018

Codecov Report

Merging #286 into master will decrease coverage by 0.47%.
The diff coverage is 75%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #286      +/-   ##
===========================================
- Coverage     67.97%   67.5%   -0.48%     
+ Complexity     1013    1007       -6     
===========================================
  Files            73      73              
  Lines          4275    4271       -4     
  Branches        610     609       -1     
===========================================
- Hits           2906    2883      -23     
- Misses         1001    1017      +16     
- Partials        368     371       +3
Impacted Files Coverage Δ Complexity Δ
.../ipc/netty/channel/PooledClientContextHandler.java 60.86% <ø> (-9.05%) 24 <0> (-4)
...ctor/ipc/netty/resources/DefaultPoolResources.java 73.17% <75%> (+0.09%) 8 <0> (ø) ⬇️
...java/reactor/ipc/netty/channel/ContextHandler.java 71.56% <0%> (-4.91%) 26% <0%> (-2%)
.../ipc/netty/http/client/HttpClientWSOperations.java 73.97% <0%> (-2.74%) 18% <0%> (-1%)
...a/reactor/ipc/netty/channel/ChannelOperations.java 81.95% <0%> (-1.51%) 47% <0%> (-1%)
...or/ipc/netty/channel/ChannelOperationsHandler.java 62.93% <0%> (-1.17%) 56% <0%> (-1%)
...in/java/reactor/ipc/netty/channel/FluxReceive.java 81.63% <0%> (-1.03%) 64% <0%> (ø)
...or/ipc/netty/http/server/HttpServerOperations.java 68.45% <0%> (+0.59%) 47% <0%> (+1%) ⬆️
.../ipc/netty/http/client/MonoHttpClientResponse.java 81.08% <0%> (+4.05%) 6% <0%> (ø) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a28d6d1...f97aaa3. Read the comment docs.

@smaldini smaldini merged commit 9e33be5 into master Feb 14, 2018
@smaldini smaldini deleted the closeEventPoolRelease branch February 14, 2018 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants