Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow throwing Exception if stream resource is not supported #158

merged 1 commit into from Mar 26, 2018


Copy link

@clue clue commented Mar 26, 2018

This very simple PR adds documentation to make consumers aware that addReadStream() and addWriteStream() MAY throw an Exception if the given stream resource type is not supported by the underlying event loop implementation. This is explicitly not enforced due to performance considerations, so consumers SHOULD NOT rely on this.

Builds on top of #110

@WyriHaximus WyriHaximus merged commit 1fb6a4b into reactphp:master Mar 26, 2018
@clue clue deleted the exception branch March 26, 2018 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants