Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] LibUvLoop: Add new LibUvLoop (unofficial ext-libuv) #17

Closed
wants to merge 10 commits into from

Conversation

steverhoades
Copy link
Contributor

This event loop is currently passing on a debian system with PHP 5.6 and php-uv available here https://github.com/steverhoades/php-uv/tree/libuv-1.0

There are still some segfault issues with the php-uv extension that I am trying to fix.

@steverhoades
Copy link
Contributor Author

All tests are now passing, what else is needed to get this merged?

/cc @WyriHaximus @cboden

@WyriHaximus
Copy link
Member

@steverhoades this is awesome news :D! Got two small things: So I'm missing an ext-uv in composer.json, not sure if it should point to your repo or another? Another thing is a mention about the UV event loop in the readme file 👍

@steverhoades
Copy link
Contributor Author

@WyriHaximus I'll get that updated it should now point to bwoebi's php-uv fork as his fork is being actively maintained. The other consideration that I just thought of is that this version of php-uv only supports PHP 7. We could do a version check for the time being. I'll take a look at the extension and see what effort would be required to port a version for PHP 5 -

@WyriHaximus
Copy link
Member

@steverhoades Having at for PHP7 already makes me really happy. PHP5 is a must tbh and a version check would do for now, please ping me if I can help you test PHP5 support

@sinasalek
Copy link

Has this been merged ?

@cebe
Copy link
Contributor

cebe commented Apr 22, 2016

@sinasalek no.

@clue
Copy link
Member

clue commented May 20, 2016

Unfortunately this is still marked as WIP, is there anything we can do to help this progress? 👍

@clue clue changed the title WIP - restarting libuv support [WIP] LibUvLoop: Add new LibUvLoop (libuv) Feb 8, 2017
@clue
Copy link
Member

clue commented Feb 8, 2017

Ping @steverhoades, what's the status here? :shipit:

@clue clue changed the title [WIP] LibUvLoop: Add new LibUvLoop (libuv) [WIP] LibUvLoop: Add new LibUvLoop (unofficial ext-libuv) Dec 4, 2017
@clue
Copy link
Member

clue commented Dec 4, 2017

Thank you for working on this and helping push this forward! This is kind of an old PR and it looks like #112 is the most up to date version of this feature, so I'm closing this one in favor of the newer PR :shipit: This should help us focusing on shipping this in a future version 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants