Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .gitattributes to exclude dev files from exports #201

Merged
merged 1 commit into from Dec 21, 2019

Conversation

@reedy
Copy link
Contributor

reedy commented Dec 1, 2019

As per discussion at reactphp/promise#153

@reedy reedy force-pushed the reedy:gitattributes branch from cd49423 to b7687ee Dec 1, 2019
@reedy reedy changed the title Create .gitattributes Add .gitattributes to exclude dev files from exports Dec 1, 2019
@reedy reedy force-pushed the reedy:gitattributes branch from b7687ee to e7e9d98 Dec 2, 2019
@WyriHaximus WyriHaximus requested review from WyriHaximus, clue and jsor Dec 2, 2019
@WyriHaximus WyriHaximus added this to the v1.1.1 milestone Dec 2, 2019
@clue
clue approved these changes Dec 2, 2019
Copy link
Member

clue left a comment

@reedy Changes LGTM, unrelated build error is being addressed in #202 :shipit:

Copy link
Member

clue left a comment

@reedy Just noticed that the travis-init.sh is missing, can you add/amend this 👍

@reedy reedy force-pushed the reedy:gitattributes branch from e7e9d98 to a949df7 Dec 20, 2019
@reedy reedy requested a review from clue Dec 20, 2019
Copy link
Member

WyriHaximus left a comment

LGTM now 👍

@jsor
jsor approved these changes Dec 20, 2019
@clue
clue approved these changes Dec 21, 2019
@clue clue merged commit f331f95 into reactphp:master Dec 21, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.