ExtUvLoop: Fix reporting connection refused errors #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clue
force-pushed
the
ext-uv-connections
branch
2 times, most recently
from
515c6d7
to
255aeaa
Compare
clue
force-pushed
the
ext-uv-connections
branch
from
255aeaa
to
527c60a
Compare
The underlying `epoll_wait()` reports `EPOLLOUT|EPOLLERR|EPOLLHUP` on the affected file descriptor, which `ext-uv` emits as an error code `EBADF` with no events attached. We explicitly re-enable all active events on this error event to invoke the writable listener for this condition to match other event loop implementations and successfully detect this as a refused connection attempt. All tests are now green.
clue
changed the title
clue
changed the title
|
It works! 🎉 The underlying For future reference, here's how to install this extension in a sample Docker container and all the commands I've used to debug this issue: docker run -it -v /home/me/workspace:/workspace --workdir=workspace ubuntu:latest bash
apt update
apt-get install -y software-properties-common
add-apt-repository ppa:ondrej/php -y
apt-get install -y libuv1-dev php-pear php-dev strace
pecl install uv-beta
echo "extension=uv" >> "$(php -r 'echo php_ini_loaded_file();')"
php -m
cd /workspace
strace php examples/14-http-client-async.php
php -r 'var_dump((new ReflectionClass("UV"))->getConstants());'
vendor/bin/phpunitNow let's get this shipped! |
jsor
approved these changes
Dec 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes reporting "connection refused" on affected installation of ExtUvLoop. I have started with adding relevant tests to the test matrix, fixing the underlying issue and included additional tests to run run this on Windows as well.
Resolves #188
Builds on top of #205
Refs #206 to skip a similar problem for the
StreamSelectLoopon Windows only.