Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis improvements #74

Merged
merged 7 commits into from Feb 6, 2017
Merged

Conversation

@jsor
Copy link
Member

@jsor jsor commented Feb 6, 2017

Main changes are:

@@ -5,9 +5,23 @@ php:
- 5.5
- 5.6
- 7.0
- 7.1
Copy link
Contributor

@kelunik kelunik Feb 6, 2017

+ nightly maybe?

Copy link
Member Author

@jsor jsor Feb 6, 2017

Maybe something we can add in another PR since it would probably introduce allow_failures also.

Copy link
Contributor

@kelunik kelunik Feb 6, 2017

Yes, allow_failures is a good idea for nightly.

clue
clue approved these changes Feb 6, 2017
@@ -5,9 +5,23 @@ php:
- 5.5
- 5.6
- 7.0
- 7.1
Copy link
Member

@clue clue Feb 6, 2017

Not sure if we have a consensus here yet. Do we really want to add every single future version for all components?

Other than that, LGTM 👍

Copy link
Member Author

@jsor jsor Feb 6, 2017

I'd say yes. Since this is a core component, i think we should run the tests against as much versions as possible.

But i agree that this change should have probably been introduced in another PR.

Copy link
Member Author

@jsor jsor Feb 6, 2017

Not sure if we have a consensus here yet. Do we really want to add every single future version for all components?

Have re-read this now: I think it makes sense for this component. If this makes sense for all components is arguable.

Copy link
Member

@WyriHaximus WyriHaximus Feb 6, 2017

Personally I would prefer testing all versions we support to ensure we don't run into weird issues. We also might want to use the new cron feature to schedule builds, but that only makes sense with nightly tbh.

@jsor jsor requested a review from WyriHaximus Feb 6, 2017
Copy link
Member

@WyriHaximus WyriHaximus left a comment

1 minor comment but the rest looks good 👍

.travis.yml Outdated

cache:
directories:
- $HOME/.composer/cache
Copy link
Member

@WyriHaximus WyriHaximus Feb 6, 2017

Changing this to $HOME/.composer/cache/files will ensure we only cache package files and not the meta files.

Copy link
Member Author

@jsor jsor Feb 6, 2017

Done

@WyriHaximus WyriHaximus merged commit 1bb5263 into reactphp:master Feb 6, 2017
1 check passed
@jsor jsor deleted the travis-improvements branch Feb 6, 2017
@clue clue added this to the v0.4.3 milestone Feb 8, 2017
@clue clue added this to the v0.5.0 milestone Feb 8, 2017
@clue clue removed this from the v0.4.3 milestone Feb 8, 2017
@clue
Copy link
Member

@clue clue commented Feb 8, 2017

For the reference: Updated the milestone to "v0.5.0" because this actually landed in the master branch instead of the "0.4" release branch (because it's been merged after #72).

clue added a commit to clue-labs/event-loop that referenced this issue Feb 8, 2017
This contains all changes from reactphp#74 squashed into a single commit:

* Remove deprecated --dev option from composer install
* Remove --prefer-source from composer install
* Move composer install to .travis.yml
* Enable container based infrastructure on travis
* Enable travis cache
* Add PHP 7.1 to test matrix
* Adjust composer cache directory to only cache package files
WyriHaximus added a commit that referenced this issue Feb 8, 2017
Travis improvements (backported from #74)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants