Skip to content

Fix file read example in Readme #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2018
Merged

Fix file read example in Readme #17

merged 1 commit into from
Jun 20, 2018

Conversation

seregazhuk
Copy link
Contributor

@seregazhuk seregazhuk commented Feb 18, 2018 •
edited
Loading

This PR provides a fix for reading the contents of a file example in Readme. There is no such method open($filename) in FilesystemInterface, so I assume that there should be a chain of file() and open() calls.

@WyriHaximus WyriHaximus added this to the v0.1.1 milestone Feb 20, 2018
WyriHaximus
WyriHaximus approved these changes Jun 20, 2018
View reviewed changes
Copy link
Member

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you :shipit:

@WyriHaximus WyriHaximus merged commit 4089034 into reactphp:master Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsor jsor jsor approved these changes

@WyriHaximus WyriHaximus WyriHaximus approved these changes

@clue clue clue approved these changes

Assignees
No one assigned
Labels
easy pick maintenance
Projects
None yet
Milestone
v0.1.1
Development

Successfully merging this pull request may close these issues.
4 participants
@seregazhuk @jsor @WyriHaximus @clue