Use array access, and remove unnecessary double error from array lookup
#25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clue
reviewed
May 28, 2018
| }, function (Payload $payload) { | ||
| return \React\Promise\reject(new Exception($payload->getPayload()['error']['error']['message'])); | ||
| }, function ($payload) { | ||
| return \React\Promise\reject(new Exception($payload['error']['message'])); |
There was a problem hiding this comment.
The title suggests there must be a way to verify this is "the correct way"? 
There was a problem hiding this comment.
Yeah using array access and ditching the extra error index solve the errors.
(Also updated the title.)
There was a problem hiding this comment.
Is this tested or can we add some tests for this? 👍
There was a problem hiding this comment.
Added a test for this 👍
WyriHaximus
changed the title
error from array lookup
…he promises to the callee, via @clue at reactphp#25 (comment)
clue
approved these changes
Jun 18, 2018
jsor
approved these changes
Jun 18, 2018
WyriHaximus
added a commit
to WyriHaximus-labs/filesystem
that referenced
this pull request
Feb 14, 2021
…he promises to the callee, via @clue at reactphp#25 (comment)
WyriHaximus
added a commit
to WyriHaximus-labs/filesystem
that referenced
this pull request
Oct 5, 2021
…he promises to the callee, via @clue at reactphp#25 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.