Skip to content

Reworked file copying to use pipe #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2018
Merged

Reworked file copying to use pipe #40

merged 1 commit into from
Jul 28, 2018

Conversation

WyriHaximus
Copy link
Member

This solves the event loop time out as streaming closing is pickedup correctly.

@WyriHaximus WyriHaximus added this to the v0.1.1 milestone Jul 18, 2018
@WyriHaximus WyriHaximus requested a review from clue July 23, 2018 17:34
@WyriHaximus
Copy link
Member Author

While this PR doesn't pass builds, it's a huge step forwards and I prefer to fix the stalled builds in a follow up PR.

clue
clue approved these changes Jul 28, 2018
View reviewed changes
Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build output suggests this improves a number of build errors, so let's get this in :shipit: 👍

@WyriHaximus WyriHaximus merged commit 542acfa into reactphp:master Jul 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clue clue clue approved these changes

Assignees
No one assigned
Labels
help wanted maintenance
Projects
None yet
Milestone
v0.1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@WyriHaximus @clue