Skip to content

Conversation

localheinz
Copy link
Contributor

@localheinz localheinz commented Jul 23, 2018

This PR

  • provides an example for tailing a log file

Fixes #12.

/cc @WyriHaximus

@WyriHaximus WyriHaximus added this to the v0.1.1 milestone Jul 23, 2018
@WyriHaximus WyriHaximus requested review from WyriHaximus and clue July 23, 2018 20:58
Copy link
Member

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

P.S. Test failure are unrelated

@WyriHaximus
Copy link
Member

@clue what do you think? This looks good to me :)

@WyriHaximus WyriHaximus merged commit 65c6d55 into reactphp:master Aug 2, 2018
@localheinz localheinz deleted the feature/example branch August 2, 2018 11:50
@localheinz
Copy link
Contributor Author

Thank you, @jsor and @WyriHaximus!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants