Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PHPUnit configuration schema for PHPUnit 9.3 #44

merged 1 commit into from Sep 27, 2020


Copy link

PHPUnit 9.3 released a new schema for the phpunit.xml configuration file. I had to migrate the file to the new format in order to avoid the warning. PHPUnit Versions older than 9.3 have to use the phpunit.xml.legacy configuration file, because the new format is unknown for them.
For further details concerning this pull request look into graphp/graphviz#46.
This pull request builds on top of #42 .

It's also possible to run this code with PHP 8 馃帀

$ docker run -it --rm -v `pwd`:/data --workdir=/data php:8.0.0beta2-cli php vendor/bin/phpunit
PHPUnit 9.3.10 by Sebastian Bergmann and contributors.

.....................................                             37 / 37 (100%)

Time: 00:00.138, Memory: 6.00 MB

OK (37 tests, 67 assertions)

@clue clue added this to the v1.7.0 milestone Sep 23, 2020
Copy link

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Thanks for the update, changes LGTM! :shipit:

@WyriHaximus WyriHaximus self-requested a review September 23, 2020 12:10
@jsor jsor merged commit 272db30 into reactphp:master Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants