Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve TLS error messages and cancellation forwarding during TLS handshake after TCP/IP connection #177

merged 4 commits into from Sep 28, 2018


Copy link

@clue clue commented Sep 27, 2018

This PR improves TLS error messages (if connector fails due to TLS handshake errors) and improves (fixes) cancellation forwarding after the TCP/IP connection. This ensures that cancelling a pending connection attempt will properly cancel the underlying TCP/IP connection attempt and/or the TLS handshake.

The cancellation forwarding will eventually also be addressed upstream via reactphp/promise#99, but it's currently not decided when this version will be tagged. In the meantime, this PR works around this issue and improves cancellation semantics somewhat.

Refs #168, #169, #170, #171 and #176

@clue clue added this to the v1.1.0 milestone Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants