Ignore HHVM errors when closing connection that is already closing #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WyriHaximus
approved these changes
Apr 10, 2017
jsor
approved these changes
Apr 10, 2017
clue
added a commit
to clue-labs/socket
that referenced
this pull request
Apr 22, 2017
Documentation for supported PHP versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HHVM raises a PHP warning when trying to shut down a socket that is already closing because the other side closed the connection. This does not happen for any other PHP version, so simply ignore this error as part of the shut down procedure.
Refs clue/reactphp-http-proxy#9 and https://travis-ci.org/clue/php-http-proxy-react/jobs/220595506