New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EPUB version check #33

Closed

danielweck opened this issue Apr 4, 2017 · 3 comments

Member

danielweck commented Apr 4, 2017

https://github.com/readium/r2-streamer-go/blob/master/parser/epub.go#L202

if epubVersion == "3.0" {
}

should be:

if isEpub3OrMore(book) {
}

Member Author

danielweck commented Apr 4, 2017

Also in:
https://github.com/readium/r2-streamer-go/blob/master/parser/epub.go#L104

	if epubVersion == epub3 {

Member Author

danielweck commented Apr 4, 2017

Note that refines is deprecated, not superseded:
http://www.idpf.org/epub/31/spec/epub-changes.html#sec-pkg-refines
http://www.idpf.org/epub/31/spec/epub-packages.html#attrdef-meta-refines
http://www.idpf.org/epub/31/spec/epub-spec.html#deprecated
"Reading Systems must continue to support the feature as it is defined until it is formally removed."

banux pushed a commit that referenced this issue


          related #33, use the newer function for epub version checking

9bc7ad7

Contributor

banux commented Apr 6, 2017

Yes we can try to check it. I don't close the issue so we can tackle this later.

banux pushed a commit that referenced this issue


          related #33, fix typo

98fdd6b

HadrienGardeur closed this as not planned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment