Skip to content
This repository has been archived by the owner on Jul 29, 2022. It is now read-only.

Fix copy and print restrictions and information #104

Merged
merged 4 commits into from
Mar 1, 2021
Merged

Fix copy and print restrictions and information #104

merged 4 commits into from
Mar 1, 2021

Conversation

qnga
Copy link
Contributor

@qnga qnga commented Feb 25, 2021

Because license.charactersToCopyLeft and license.pagesToPrintLeft were always null, right informations were wrong, and copy and print were unrestricted.

Fix readium/r2-testapp-kotlin#267

@mickael-menu
Copy link
Member

I will wait for the next beta to be out before merging this, as I already did all the tests. For information LCP copy is not yet implemented on Android, so this part was actually not really used.

@llemeurfr
Copy link

@mickael-menu when you say LCP copy is not yet implemented on Android, do you mean by the testapp, by all apps you know about, or simply because developers have so far hidden the copy button?

@mickael-menu
Copy link
Member

@llemeurfr All of these actually. Do you know any app that actually implemented LCP copy on Android? Technically r2-lcp-kotlin is ready to save right consumption, but it's not trivial to actually implement it in the navigator or reading apps.

@llemeurfr
Copy link

In practice all app I've seen so far were blocking copy by deleting the copy/share button, which is far from being perfect, we all agree.

@mickael-menu
Copy link
Member

Yes by "not implementing copy" I meant authorizing only the number of characters allowed in the license. The test app is disabling copy indeed.

Copy link
Member

@mickael-menu mickael-menu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qnga Works well, thanks!

@mickael-menu mickael-menu merged commit e8338a6 into readium:develop Mar 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LCP, info panel always show prints and copy left unlimited
3 participants