-
Notifications
You must be signed in to change notification settings - Fork 9
Conversation
Leaving in draft until I figure out why the dialog for inputting the passphrase isn't showing much. |
Nice, thanks! I created a dedicated 3.0.0 epic to list the changes to be made: https://github.com/readium/r2-testapp-kotlin/issues/454 |
Do you want to be rid of needing a database for this by 3.0? If not, then this is fine, but we should deprecate the relevant functions/vals sooner than later. |
Not necessarily as it's convenient to have a default implementation. The idea is to give the control back to the apps if they want it though, regarding passphrase persistence. |
I also changed how the Bluetooth adapter's name is retrieved, as There is plenty of other refactoring that can be done, especially with the checks to |
r2-lcp/src/main/java/org/readium/r2/lcp/persistence/Database.kt
Outdated
Show resolved
Hide resolved
r2-lcp/src/main/java/org/readium/r2/lcp/persistence/Licenses.kt
Outdated
Show resolved
Hide resolved
r2-lcp/src/main/java/org/readium/r2/lcp/persistence/Licenses.kt
Outdated
Show resolved
Hide resolved
r2-lcp/src/main/java/org/readium/r2/lcp/persistence/Licenses.kt
Outdated
Show resolved
Hide resolved
r2-lcp/src/main/java/org/readium/r2/lcp/persistence/Transactions.kt
Outdated
Show resolved
Hide resolved
r2-lcp/src/main/java/org/readium/r2/lcp/service/LicensesRepository.kt
Outdated
Show resolved
Hide resolved
r2-lcp/src/main/java/org/readium/r2/lcp/service/PassphrasesRepository.kt
Outdated
Show resolved
Hide resolved
r2-lcp/src/main/java/org/readium/r2/lcp/service/PassphrasesRepository.kt
Outdated
Show resolved
Hide resolved
r2-lcp/src/main/java/org/readium/r2/lcp/service/LicensesRepository.kt
Outdated
Show resolved
Hide resolved
r2-lcp/src/main/java/org/readium/r2/lcp/service/PassphrasesService.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvement, thank you!
For the next release where we have a breaking change, we need to make the calls made to the database in https://github.com/stevenzeck/r2-lcp-kotlin/blob/room/r2-lcp/src/main/java/org/readium/r2/lcp/license/License.kt to be asynchronous.