Skip to content
This repository has been archived by the owner on Jul 29, 2022. It is now read-only.

Migrate from Anko to Room #116

Merged
merged 9 commits into from
Sep 9, 2021
Merged

Migrate from Anko to Room #116

merged 9 commits into from
Sep 9, 2021

Conversation

stevenzeck
Copy link
Contributor

@stevenzeck stevenzeck commented Aug 14, 2021

For the next release where we have a breaking change, we need to make the calls made to the database in https://github.com/stevenzeck/r2-lcp-kotlin/blob/room/r2-lcp/src/main/java/org/readium/r2/lcp/license/License.kt to be asynchronous.

@stevenzeck stevenzeck marked this pull request as draft August 14, 2021 20:44
@stevenzeck
Copy link
Contributor Author

Leaving in draft until I figure out why the dialog for inputting the passphrase isn't showing much.

@stevenzeck stevenzeck marked this pull request as ready for review August 14, 2021 21:09
@mickael-menu
Copy link
Member

Nice, thanks!

I created a dedicated 3.0.0 epic to list the changes to be made: https://github.com/readium/r2-testapp-kotlin/issues/454

@stevenzeck
Copy link
Contributor Author

Do you want to be rid of needing a database for this by 3.0? If not, then this is fine, but we should deprecate the relevant functions/vals sooner than later.

@mickael-menu
Copy link
Member

Do you want to be rid of needing a database for this by 3.0? If not, then this is fine, but we should deprecate the relevant functions/vals sooner than later.

Not necessarily as it's convenient to have a default implementation. The idea is to give the control back to the apps if they want it though, regarding passphrase persistence.

@stevenzeck
Copy link
Contributor Author

I also changed how the Bluetooth adapter's name is retrieved, as BluetoothAdapter.getDefaultAdapter() is deprecated with API 31.

There is plenty of other refactoring that can be done, especially with the checks to exists and isDeviceRegistered, but another day.

Copy link
Member

@mickael-menu mickael-menu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement, thank you!

@mickael-menu mickael-menu merged commit 01470eb into readium:develop Sep 9, 2021
@mickael-menu mickael-menu mentioned this pull request Oct 25, 2021
14 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants