Skip to content
This repository has been archived by the owner on Jul 29, 2022. It is now read-only.

Removed 'application' element from AndroidManifest.xml. #93

Merged
merged 1 commit into from
Mar 9, 2020
Merged

Removed 'application' element from AndroidManifest.xml. #93

merged 1 commit into from
Mar 9, 2020

Conversation

twaddington
Copy link
Contributor

The library manifest had defined the attributes 'allowBackup'
and 'supportsRtl'. This may result in a manifest merge error
requiring implementors to use an override like 'tools:replace'.

The library manifest had defined the attributes 'allowBackup'
and 'supportsRtl'. This may result in a manifest merge error
requiring implementors to use an override like 'tools:replace'.
@mickael-menu
Copy link
Member

Thanks for your contribution.

It seems to be a pretty common issue caused by Android Studio's default manifest for libraries:

https://medium.com/@elye.project/2-lines-in-manifest-to-remove-when-sharing-your-android-library-565d4c4af04a

@mickael-menu
Copy link
Member

@twaddington I'm ready to merge these PRs, but first I want to confirm something with you: You didn't push a PR with this fix for r2-navigator-kotlin, I guess it's just an oversight?

https://github.com/readium/r2-navigator-kotlin/blob/develop/r2-navigator/src/main/AndroidManifest.xml

@twaddington
Copy link
Contributor Author

@twaddington I'm ready to merge these PRs, but first I want to confirm something with you: You didn't push a PR with this fix for r2-navigator-kotlin, I guess it's just an oversight? — @mickael-menu

Yep! Looks like I missed that one. There are a lot of repos 😂

Happy to put up a PR for the navigator today too.

@mickael-menu
Copy link
Member

@twaddington Thanks! I'll merge the other ones in the meantimes.

@mickael-menu mickael-menu merged commit 38a0ce4 into readium:develop Mar 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants