Highlights: jQuery touch event "undefined" bug

[danielweck]

https://github.com/readium/readium-shared-js/blob/develop/plugins/highlights/models/group.js#L376
var lastTouch = _.last(e.changedTouches);
changedTouches is undefined, should be e.originalEvent.changedTouches
(e is jQuery event)

[danielweck]

CC @jccr

[danielweck]

Reported by @nimisis at readium/SDKLauncher-iOS#91 (comment)

[danielweck]

Also reported by @kivuto (Texidium)

[danielweck]

Fixed: 5c24c38

[danielweck]

Note: was fixed in Mantano's PR!
https://github.com/readium/readium-shared-js/pull/237/files#diff-652783b831d1c9386c3194019f6820d1L377

[sercanl]

Hi @danielweck ,

I wonder if this commit (5c24c38) is still valid in later versions of Readium. I looked it up in various releases, but couldn't find it. I am struggling with an iOS touchend problem which is triggered from group.js file. ( inside boundHighlightCallback(...) )

Error message in console: TypeError: undefined is not an object (evaluating 's.pageX')

[danielweck]

The "highlight" plugin (previously-named "annotation") was an experiment implemented by @jccr / @evidentpoint (if I remember correctly) and although it showed a lot of promise, it was incomplete and unmaintained. So the pragmatic solution was to replace it with the "hypothesis" plugin which delegates the entire functionality to the cloud service https://web.hypothes.is