Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

fix: updating oas to fix a bug with shapeless allOf child schemas #1190

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

erunion
Copy link
Member

@erunion erunion commented Feb 18, 2021

☁️   CI App

🧰 What's being changed?

This updates our oas dependency to fix a bug where shapeless children of an allOf would receive a type when they shouldn't. For example:

allOf: [
  { 
    type: 'array', 
    items: { 
      type: 'string' 
    }
  }, 
  { description: 'Parameter description' } // This ends up receiving `type: string`.
],

This also pulls in some JWT default handling that's being integrated within #1189.

🧬 Testing

This AWS Workspaces spec fails on the preview site.

Screen Shot 2021-02-18 at 9 47 03 AM

But works now with this fix.

Screen Shot 2021-02-18 at 9 48 16 AM

📖 Release Notes

10.1.1 (2021-02-18)

10.1.0 (2021-02-17)

@erunion erunion added type:bug Something isn't working scope:dependency Pull requests that update a dependency file labels Feb 18, 2021
@erunion erunion temporarily deployed to explorer-pr-1190 February 18, 2021 17:47 Inactive
@erunion erunion merged commit 524a788 into next Feb 18, 2021
@erunion erunion deleted the fix/allOf-shapeless-bugs branch February 18, 2021 17:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope:dependency Pull requests that update a dependency file type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant