Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: zsh compatibility for api installation instructions #875

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

erunion
Copy link
Member

@erunion erunion commented Apr 11, 2024

🧰 Changes

Running npx api install @handbook/v1.0#fzmso1cluu0vbwv on a Zsh environment breaks because the hash there sends Zsh into a tizzy. Wrapping our registry identifiers for api in quotes fixes this.

@erunion erunion requested a review from kanadgupta April 11, 2024 20:47
@erunion erunion added bug Something isn't working area:snippets Issues related to code snippets labels Apr 11, 2024
Copy link
Member

@kanadgupta kanadgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once tests pass 👍🏽

@erunion erunion merged commit 858b485 into main Apr 11, 2024
6 checks passed
@erunion erunion deleted the fix/install-script-zsh-compat branch April 11, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:snippets Issues related to code snippets bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants