-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support other package managers #895
feat: support other package managers #895
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per @erunion's comment, could you use preferred-pm
instead? I'd feel much better about deferring to a maintained library with coverage for this logic as opposed to maintaining it ourselves. Thanks @DaniAkash!
Sure! I'll add the change 👍🏽 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @DaniAkash!
has this landed on main? I am getting:
when running
I can't find any mention of #894 in the changelog on https://github.com/readmeio/api/releases, however 21230f8 I can see it is part of v7.0.0-beta.8, though when running beta.8 via deno run --allow-read --allow-run --allow-env --allow-sys --allow-write=.api npm:api@7.0.0-beta.8 install ./openapi/2024-08-28.json I still get:
it still seems to invoke |
Understood. It doesn't seem to be working as expected on |
@joscha mind filing a new issue for this? Thanks! |
Sorry, after there was no answer and I also read somewhere else in this repo that it doesn't support distribution, I moved to https://github.com/OpenAPITools/openapi-generator. |
🧰 Changes
Added a detection logic for deno, bun, yarn & pnpm before running the install command.
🧬 QA & Testing
Running this project in the above environments to try if the package gets installed correctly.