refactor: slimming down the size of our unicode dump by removing unneeded data #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafegoldberg
changed the title
rafegoldberg
approved these changes
Nov 19, 2020
domharrington
approved these changes
Nov 19, 2020
There was a problem hiding this comment.
Amazing thank you! Wonder how other people do this...
Seems like this module has a similar problem too: https://github.com/ealush/emoji-picker-react/blob/master/src/emojis.json
Happy with this, but will be good when we can only include this on the Tutorials page.
|
Wonder how much smaller we could make it by replacing "emoji", "aliases" and "ios_version" in the json with smaller keys. |
|
Made another change to store the emoijs as an array of arrays: Bundle is now 44k. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes some drastic reductions to the size of our emoji Unicode dump (by way of gemoji) by removing data that we aren't actually using within the EmojiPicker.
Since we actually utilize
emoji,aliases, andios_versionthere it doesn't make sense for us to ship a JSON dump of unnecessary that tops out at ~400KB.With these reductions
unicode/index.jsoncaps out at 120KB, an almost 60% drop in size.