Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support legacy gemoji #873

Merged
merged 2 commits into from
May 7, 2024
Merged

Conversation

kellyjosephprice
Copy link
Collaborator

PR App Fix RM-9702

🧰 Changes

Adds support for our legacy emoji syntax.

Previously, we swapped out our custom emoji library for a more standard one. Unrealized by me, our custom one used dashes instead of underscores. This checks if the same emoji name exists using underscores instead of dashes.

🧬 QA & Testing

@kellyjosephprice kellyjosephprice marked this pull request as ready for review May 6, 2024 23:01
Copy link
Member

@erunion erunion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks-good-to-me

@kellyjosephprice kellyjosephprice merged commit c34b8fe into next May 7, 2024
12 of 13 checks passed
@kellyjosephprice kellyjosephprice deleted the feat/support-legacy-gemoji branch May 7, 2024 21:20
rafegoldberg pushed a commit that referenced this pull request May 7, 2024
## Version 6.83.0

### ✨ New & Improved

* support legacy gemoji ([#873](#873)) ([c34b8fe](c34b8fe))

<!--SKIP CI-->
@rafegoldberg
Copy link
Contributor

This PR was released!

🚀 Changes included in v6.83.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants