fix: messy issues with nodeVersionUtils helper needing semver installed (#489)

Author: erunion

__tests__/bin.test.js

@@ -1,5 +1,5 @@
 const { exec } = require('child_process');
-const { isSupportedNodeVersion } = require('../src/lib/nodeVersionUtils');
+const isSupportedNodeVersion = require('../src/lib/isSupportedNodeVersion');
 const pkg = require('../package.json');
 
 describe('bin', () => {

__tests__/lib/getNodeVersion.test.js

@@ -0,0 +1,11 @@
+const getNodeVersion = require('../../src/lib/getNodeVersion');
+const pkg = require('../../package.json');
+const semver = require('semver');
+
+describe('#getNodeVersion()', () => {
+  it('should extract version that matches range in package.json', () => {
+    const version = parseInt(getNodeVersion(), 10);
+    const cleanedVersion = semver.valid(semver.coerce(version));
+    expect(semver.satisfies(cleanedVersion, pkg.engines.node)).toBe(true);
+  });
+});

__tests__/lib/nodeVersionUtils.test.js renamed to __tests__/lib/isSupportedNodeVersion.test.js

@@ -1,6 +1,4 @@
-const { isSupportedNodeVersion, getNodeVersion } = require('../../src/lib/nodeVersionUtils');
-const pkg = require('../../package.json');
-const semver = require('semver');
+const isSupportedNodeVersion = require('../../src/lib/isSupportedNodeVersion');
 
 describe('#isSupportedNodeVersion()', () => {
   it('should return true for a supported version of node', () => {
@@ -14,11 +12,3 @@ describe('#isSupportedNodeVersion()', () => {
     expect(isSupportedNodeVersion('18.0.0')).toBe(false);
   });
 });
-
-describe('#getNodeVersion()', () => {
-  it('should extract version that matches range in package.json', () => {
-    const version = parseInt(getNodeVersion(), 10);
-    const cleanedVersion = semver.valid(semver.coerce(version));
-    expect(semver.satisfies(cleanedVersion, pkg.engines.node)).toBe(true);
-  });
-});

bin/rdme

@@ -7,7 +7,7 @@ const updateNotifier = require('update-notifier');
 const pkg = require('../package.json');
 
 const isGHA = require('../src/lib/isGitHub');
-const { isSupportedNodeVersion } = require('../src/lib/nodeVersionUtils');
+const isSupportedNodeVersion = require('../src/lib/isSupportedNodeVersion');
 
 updateNotifier({ pkg }).notify();
 

bin/set-version-output

@@ -1,6 +1,6 @@
 #! /usr/bin/env node
 
-const { getNodeVersion } = require('../src/lib/nodeVersionUtils');
+const getNodeVersion = require('../src/lib/getNodeVersion');
 const pkg = require('../package.json');
 
 const name1 = 'RDME_VERSION';

src/lib/getNodeVersion.js

@@ -0,0 +1,10 @@
+const pkg = require('../../package.json');
+
+/**
+ * @example 14
+ * @returns {String} The maximum major Node.js version specified in the package.json
+ */
+module.exports = function getNodeVersion() {
+  const { node } = pkg.engines;
+  return Array.from(node.matchAll(/\d+/g)).pop();
+};

src/lib/isSupportedNodeVersion.js

@@ -0,0 +1,10 @@
+const semver = require('semver');
+const pkg = require('../../package.json');
+
+/**
+ * Determine if the current version of Node is one that we explicitly support.
+ *
+ */
+module.exports = function isSupportedNodeVersion(version) {
+  return semver.satisfies(semver.coerce(version), pkg.engines.node);
+};