Run application from uv
#257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running on Ubuntu 24.04, we cannot use `--system` anymore because pip complains about it. I understand we are forced to create a virtualenv when creating the Docker image. Due to that, we need to run our application using that virtualenv we created at build time. We use `uv run` for that.
stsewd
approved these changes
Feb 19, 2025
| @@ -9,7 +9,7 @@ | |||
| # Ref https://docs.celeryq.dev/en/stable/userguide/workers.html#persistent-revokes. | |||
| CELERY_STATE_DIR=/var/run/celery/ | |||
| mkdir -p $CELERY_STATE_DIR | |||
| CMD="python3 -m celery -A ${CELERY_APP_NAME}.worker worker -Ofair -c 1 -Q builder,celery,default,build01,build:default,build:large -l ${CELERY_LOG_LEVEL} --statedb=${CELERY_STATE_DIR}worker.state" | |||
| CMD="uv run python3 -m celery -A ${CELERY_APP_NAME}.worker worker -Ofair -c 1 -Q builder,celery,default,build01,build:default,build:large -l ${CELERY_LOG_LEVEL} --statedb=${CELERY_STATE_DIR}worker.state" | |||
There was a problem hiding this comment.
Think we can just drop the number now
Suggested change
| CMD="uv run python3 -m celery -A ${CELERY_APP_NAME}.worker worker -Ofair -c 1 -Q builder,celery,default,build01,build:default,build:large -l ${CELERY_LOG_LEVEL} --statedb=${CELERY_STATE_DIR}worker.state" | |
| CMD="uv run python -m celery -A ${CELERY_APP_NAME}.worker worker -Ofair -c 1 -Q builder,celery,default,build01,build:default,build:large -l ${CELERY_LOG_LEVEL} --statedb=${CELERY_STATE_DIR}worker.state" |
There was a problem hiding this comment.
Yeah, probably. I ran all the tests with python3 and there are a lot of connected pieces. I prefer if we keep it as-is for now to avoid having to re-test everything again. It's just a syntax sugar, tho.
I want to move forward for now with this and we can come back to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running on Ubuntu 24.04, we cannot use
--systemanymore because pip complains about it. I understand we are forced to create a virtualenv when creating the Docker image.Due to that, we need to run our application using that virtualenv we created at build time. We use
uv runfor that.Required by readthedocs/readthedocs.org#12002