Add release tooling to common repo #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fork of the .org release tooling.
ericholscher
approved these changes
Apr 12, 2018
humitos
approved these changes
Apr 12, 2018
| git_rev_parse = ctx.run('git rev-parse --abbrev-ref HEAD', hide=True) | ||
| current_branch = git_rev_parse.stdout.strip() | ||
| if current_branch != 'master': | ||
| print('You must be on master branch!') |
There was a problem hiding this comment.
What about adding something like
input("""
Hey! Did you already:
1. ran `invoke prepare`
2. organize CHANGELOG.rst removing invalid PRs
3. cleanup commits
4. etc...
? [y/N]""")to avoid mistakes and remind what are the proper steps to be followed.
There was a problem hiding this comment.
This would make a good enhancement. I think we can automate the checks though:
- Check setup.cfg for a matching version to the one you're releasing
- Check the changelog for a version string matching the one you're releasing
- Check that setupcfg and changelog changes are commited
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fork of the .org release tooling.