Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide banned projects from the site #5152

Closed
ericholscher opened this issue Jan 22, 2019 · 6 comments
Closed

Hide banned projects from the site #5152

ericholscher opened this issue Jan 22, 2019 · 6 comments
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code

Comments

@ericholscher
Copy link
Member

Change the .public and .private method of the ProjectQuerySetBase so they hide banned user's projects by default. We ban users because of spam, but don't delete them because we don't want to give spammers feedback on what's happening.

Users should probably still see their own banned projects, but nobody else, so this is a bit more complicated than a simple fix.

Refs #5097
@ericholscher ericholscher mentioned this issue Jan 22, 2019
Merged
@ericholscher ericholscher added the Needed: design decision A core team decision is required label Jan 22, 2019
@agjohnson
Copy link
Contributor

I like the method of altering the querysets to silently drop these projects. We shouldn't be linking to or promoting any of these projects on site, or in our API.

@dojutsu-user
Copy link
Member

@ericholscher
I would like to take this issue up.

@humitos
Copy link
Member

humitos commented Apr 28, 2019

@dojutsu-user you can work on it if you want. I think it's clear what it's needed to do. I'm marking this issue as Accepted.

@humitos humitos added Accepted Accepted issue on our roadmap Improvement Minor improvement to code and removed Needed: design decision A core team decision is required labels Apr 28, 2019
@dojutsu-user
Copy link
Member

@humitos
I will start working on it and will submit a PR soon.

@dojutsu-user
Copy link
Member

@humitos
I will start working on this after a few days. I am busy with the project evaluations and end semester exams right now.
Sorry for the delay.

@saadmk11 saadmk11 mentioned this issue Oct 1, 2019
Closed
@ericholscher
Copy link
Member Author

Sorry for the misleading ticket here. We are going ahead and deleting these projects, instead of filtering them out. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hide Banned Projects from the Site saadmk11/readthedocs.org
4 participants
@ericholscher @humitos @agjohnson @dojutsu-user