add trailing semicolon rule #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -96,4 +96,8 @@ class StringRuleTests: XCTestCase { | |||
| func testStatementPosition() { | |||
| verifyRule(StatementPositionRule.description) | |||
| } | |||
|
|
|||
| func testTrailingSemicolon() { | |||
| verifyRule(TrailingSemicolonRule.description, commentDoesntViolate: false) | |||
There was a problem hiding this comment.
comments shouldn't violate, we want to encourage good grammar in comments!
There was a problem hiding this comment.
It was trickier to implement, but it's done now. Thanks for the push!
jpsim
force-pushed
the
jp-trailing-semicolon
branch
from
1d94909
to
0a2b9e8
Compare
| @@ -29,15 +28,14 @@ extension XCTestCase { | |||
| ruleDescription.triggeringExamples.flatMap({ | |||
| violations($0, ruleDescription).map({$0.ruleDescription}) | |||
| }), | |||
| Array(count: ruleDescription.triggeringExamples.count, repeatedValue: ruleDescription)) | |||
| Array(count: ruleDescription.triggeringExamples.count, repeatedValue: ruleDescription) | |||
| ) | |||
|
|
|||
| if commentDoesntViolate { | |||
There was a problem hiding this comment.
maybe should also test that, if a comment does violate, the violation still happens inside a comment?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.