New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rules from Erica Sadun #202

Closed
jpsim opened this Issue Nov 17, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@jpsim
Collaborator

jpsim commented Nov 17, 2015

Lots of good stuff in here that we could turn into SwiftLint rules: http://ericasadun.com/2015/11/17/a-handful-of-swift-style-rules-swiftlang/

Notably, the following rules should be straightforward to implement:

  • The Rule of Conditional Binding Cascades (done in #327)
  • The Rule of Pattern Matching Keywords (done in #1800)
  • The Rule of isEmpty (done in #206)
  • Prefer Swift constructors to legacy ones (done in #242)
  • Avoid terminal semicolons even though they compile (done in #203)

@jpsim jpsim added the rule-request label Nov 17, 2015

@marcelofabri

This comment has been minimized.

Show comment
Hide comment
@marcelofabri

marcelofabri Nov 29, 2015

Collaborator

@jpsim About "Prefer Swift constructors to legacy ones", do you see another way than keeping a list of known legacy constructors and checking for their presence?

Collaborator

marcelofabri commented Nov 29, 2015

@jpsim About "Prefer Swift constructors to legacy ones", do you see another way than keeping a list of known legacy constructors and checking for their presence?

@jpsim

This comment has been minimized.

Show comment
Hide comment
@jpsim

jpsim Nov 29, 2015

Collaborator

That was how I was thinking of doing it, yes!

Collaborator

jpsim commented Nov 29, 2015

That was how I was thinking of doing it, yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment