Prefer Swift constructors to legacy ones

[marcelofabri]

What do you think, @jpsim?

[jpsim]

I have a few suggestions:

1. It's more performant to only scan the file for matches once, which can be done by merging all the regular expressions into one.
2. Instead of excluding comments and strings, we should check if the match is a SyntaxKind.Identifier which is more semantically correct, even though it probably won't make a difference in practice.

So this function could be refactored to this:

public func validateFile(file: File) -> [StyleViolation] {
    let constructors = ["CGRectMake", "CGPointMake", "CGSizeMake", "CGVectorMake",
        "NSMakeRange"]

    let pattern = "\\b(" + constructors.joinWithSeparator("|") + ")\\b"

    return file.matchPattern(pattern, withSyntaxKinds: [.Identifier]).map {
        StyleViolation(ruleDescription: self.dynamicType.description,
            location: Location(file: file, offset: $0.location))
    }
}

[jpsim]

This is great @marcelofabri! I only had a few minor suggestions regarding the implementation.

Could you also add an entry for this to the changelog?

Thanks for doing this.

[jpsim]

We don't use SwiftXPC in this file, so this import statement can be removed.

[marcelofabri]

🎉

[jpsim]

👍 awesome work!