add ConditionalBindingCascadeRule #327
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
|
@jpsim initial thoughts? |
added 2 commits
January 8, 2016 13:43
| @@ -9,6 +9,10 @@ | |||
| * Add AutoCorrect for StatementPositionRule. | |||
| [Raphael Randschau](https://github.com/nicolai86) | |||
|
|
|||
| * Add ConditionalBindingCascadeRule. | |||
There was a problem hiding this comment.
This is missing the two trailing spaces as described in CONTRIBUTING.md.
|
This is great 👏! It actually looks complete to me, is there a reason you marked this as [WIP]? |
added 2 commits
January 11, 2016 08:15
…ing-cascade-rule # Conflicts: # CHANGELOG.md
|
@jpsim There are still some edge cases I'm working out. One example is that |
ghost
changed the title
|
@jpsim Ok, ready for final review and merge. |
|
Great work @aamctustwo! Will merge in #338. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a rule to check for repeated
letstatements in a conditional binding cascade. (Task from #202)