Support Swift 2.3 on Xcode 8 #771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carthage update --no-build
By applying this, SourceKitten will use same version of `sourcekitd.framework` that running tests.
|
Thanks @norio-nomura, let's wait for the upstream PRs to land. |
This is a workaround for running tests on Xcode 7.3.1 while `xcode-select` points Xcode 8 as active developer directory.
Current coverage is 89.28% (diff: 100%)@@ master #771 diff @@
==========================================
Files 81 81
Lines 2771 2773 +2
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 2453 2476 +23
+ Misses 318 297 -21
Partials 0 0
|
* master: (27 commits) Change `included` to `include` Update formatting fixup changelog entry from #789 add fix to CHANGELOG.md fix Mark rule case `// MARK: -` Update CHANGELOG Add unit test for issue #786 Fix #786: Private unit test rule not scoped to tests clarify that vertical_whitespace is on by default again fix for verticalspace regex bug fix setterAccesiblity typo Adding new configuration for private outlet rules to allow private(set) Add redundant nil coalesing operator rule release 0.12.0 make Vertical Whitespace rule opt-in move changelog entry to appropriate section Release 0.11.2 Fix long lines and unit test Fixed returns doc for init methods issue-557 Move CHANGELOG item to Breaking ...
|
I updated.
|
norio-nomura
changed the title
Update / Pin dependencies for Swift 2.3 support
Update to SourceKitten 0.14.1
scottrhoyt
approved these changes
Sep 29, 2016
|
Thanks for review @scottrhoyt! 🙏 I added a CHANGELOG entry, but travis-ci does not yet start Xcode 7 job after So, I removed Xcode 7 job, because we can do since Xcode 8 has already been released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on jpsim/SourceKitten#239 and scottrhoyt/SwiftyTextTable#11