Fix initial listener not triggering for query-based listeners #6236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey - looks like you forgot to add a T:* label - could you please add one? |
kneth
approved these changes
Oct 22, 2018
nhachicha
approved these changes
Oct 22, 2018
bmunkholm
reviewed
Oct 22, 2018
| ## 5.7.1 (YYYY-MM-DD) | ||
|
|
||
| ### Fixes | ||
| * `RealmResults` listeners not triggering the initial callback for Query-based Realm when the device is offline [#6235](https://github.com/realm/realm-java/issues/6235). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6235
This bug caused the INITIAL callback from Object Store to never trigger for Query-based Realms. For devices that only created a query, this could mean they never saw the callback until the device came online as that caused a write from the server triggering the listener again.
From the perspective of the user they still got the INITIAL callback, but only for the 2nd callback from Object Store.