allow useQuery to filter or sort a collection by using a callback #5513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takameyer
force-pushed
the
andrew/realm-react/useQueryParams
branch
from
c61e1fb
to
28473f4
Compare
elle-j
approved these changes
Apr 4, 2023
) * allow useQuery to filter or sort a collection by using a callback method that gets momoized based on the dependency array * cleanup based on comments * add comment about 'queryCallback' * update documentation * change to useCallback * cleanup comment Expand on the useQuery PR * Add a working example * Fix a bug in rerendering * Give credit to contributor * Add example code Update tsdoc
takameyer
force-pushed
the
andrew/realm-react/useQueryParams
branch
from
eebf281
to
cd53557
Compare
Co-authored-by: LJ <81748770+elle-j@users.noreply.github.com>
|
Merging this, but up for retrospective comments later. |
papafe
added a commit
that referenced
this pull request
Apr 13, 2023
* main: (41 commits) allow useQuery to filter or sort a collection by using a callback (#5513) Fix `realm.create` types and 'requiredProperties' on Realm.Object constructor (#5697) Fix return type of `App.allUsers` (#5708) Removed renamed file Remove console.log Fix README instructions and bump version Bump template versions Update Templates (#5702) Moved "submodules" wireit task to "postinstall" Set up typedoc for realm-react, realm-web (#5709) Prepare for vNext (#5711) Prepare for 12.0.0-alpha.2 (#5707) Build iOS prebuilds in release by default (#5710) Use the event.sender as assignee when preparing release Updated prepare release workflow to print PR url in summary Fixing lint error fix the template app links (#5701) Expose `Sync` as named export (#5705) Enable all tests after bad rebase (#5595) Clear test state flag (#5689) ... # Conflicts: # packages/realm/src/Realm.ts
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
This adds the ability to filter and sort the return value of
useQuery, before it arrives in the component. This ensures thatfilteredandsortedare not called again whenuseQuerytriggers a re-render.This closes #5471
☑️ ToDos
Compatibilitylabel is updated or copied from previous entryCOMPATIBILITY.mdpackage.jsons (if updating internal packages)Breakinglabel has been applied or is not necessaryIf this PR adds or changes public API's: