Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add C++ examples for ctypes #213

Merged
merged 6 commits into from
Aug 18, 2021

Conversation

adam-dziedzic
Copy link
Contributor

Where to put new files:

  • New files should go into a top-level subfolder, named after the article slug. For example: my-awesome-article

How to merge your changes:

  1. Make sure the CI code style tests all pass (+ run the automatic code formatter if necessary).
  2. Find an RP Team member on Slack and ask them to review & approve your PR.
  3. Once the PR has one positive ("approved") review, GitHub lets you merge the PR.
  4. 🎉

@Znunu
Copy link
Contributor

Znunu commented Aug 14, 2021

Hi!
Thanks a lot. While I can't test them, I think they look great. I see you even bothered to make it cross platform which is nice.
There seems to be a slight overlap with thir PR. Can you take a look?
I think you need to find jima80525, if you want this merged. He's the one who wrote the article and code files.

Copy link
Contributor

@jima80525 jima80525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!


if __name__ == "__main__":
libname = pathlib.Path().absolute()
print("libname: ", libname)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good addition! nice

@dbader
Copy link
Member

dbader commented Aug 17, 2021

Cool, LGTM :) @jima80525 Do we need to make any updates to the article before I merge this or is this just a bonus added to the materials example code?

@jima80525
Copy link
Contributor

@dbader - it changes the output slightly (by adding a library: libcmult.so line to the display, but I wouldn't say that's worth an article update. If it's a big deal, I'd remove it from here, but I don't feel like that will confuse anyone.

@dbader dbader merged commit 8788205 into realpython:master Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants