Fixing error in tasks.py causing failures #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The issue is the missing context parameter, right? As mentioned here: http://docs.pyinvoke.org/en/stable/getting-started.html#defining-and-running-task-functions My guess is that it was removed in #213 because of a confusion as to what the name I think this looks good. My one suggestion would be to use a more verbose name, |
|
Alright, thanks for the hotfix there :) I'll merge this now to fix the sample code (+1 to what @gahjelle suggested re: naming) |
dbader
approved these changes
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fixing an error I missed on a PR yesterday from an interested reader. Lesson learned - I should have tested it out before approving and not just relying on visual inspection. Apologies!